Skip to content

Conversation

@zhu-xiaowei
Copy link
Contributor

Description

  1. delete custom user attributes from subsequent events

NOTE: This is a breaking change, only pipelines from version 1.1+ can handle events without custom user attribute.

General Checklist

  • Added new tests to cover change, if needed
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Dec 6, 2023
@zhu-xiaowei zhu-xiaowei requested a review from zxkane December 6, 2023 06:11
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ec2af3) 100.00% compared to head (31ac7b7) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          996      1006   +10     
  Branches       183       186    +3     
=========================================
+ Hits           996      1006   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane requested a review from chenhaiyun December 7, 2023 01:22
@zxkane zxkane merged commit e21ea66 into main Dec 7, 2023
@zxkane zxkane deleted the delete_user_attributes branch December 7, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants