Skip to content

Conversation

@zhu-xiaowei
Copy link
Contributor

Description

  1. optimize user engagement event record logic.

General Checklist

  • Added new tests to cover change, if needed
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Sep 20, 2023
@zhu-xiaowei zhu-xiaowei requested a review from zxkane September 20, 2023 09:38
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (77d901f) 100.00% compared to head (d0067c1) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #26   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          986       986           
  Branches       182       182           
=========================================
  Hits           986       986           
Files Changed Coverage Δ
src/tracker/PageViewTracker.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane changed the title feat: optimize user engagement event record logic chore: optimize user engagement event record logic Sep 21, 2023
@zxkane zxkane merged commit 0e47d74 into main Sep 21, 2023
@zxkane zxkane deleted the optimize_user_engagement branch September 21, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants