Skip to content

Conversation

zhu-xiaowei
Copy link
Contributor

Description

  1. delete hashCode form each event attribute
  2. add hashCode into request query parameter

General Checklist

  • Added new tests to cover change, if needed
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Sep 19, 2023
@zhu-xiaowei zhu-xiaowei requested a review from zxkane September 19, 2023 05:34
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (dbfe25a) 100.00% compared to head (300a305) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          990       986    -4     
  Branches       182       182           
=========================================
- Hits           990       986    -4     
Files Changed Coverage Δ
src/provider/AnalyticsEventBuilder.ts 100.00% <ø> (ø)
src/provider/Event.ts 100.00% <ø> (ø)
src/types/Analytics.ts 100.00% <ø> (ø)
src/network/NetRequest.ts 100.00% <100.00%> (ø)
src/provider/ClickstreamProvider.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhu-xiaowei zhu-xiaowei marked this pull request as draft September 19, 2023 05:36
@zhu-xiaowei zhu-xiaowei marked this pull request as ready for review September 19, 2023 05:57
@zxkane zxkane merged commit 7bbb9ef into main Sep 19, 2023
@zxkane zxkane deleted the hash_code branch September 19, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants