Skip to content
This repository was archived by the owner on Oct 4, 2024. It is now read-only.

Conversation

amiracle
Copy link
Contributor

@amiracle amiracle commented Jan 6, 2022

Issue #, if available:

Description of changes:

  • updated architecture image
  • tested with version 3.2.0 Cribl LogStream

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@amiracle amiracle requested a review from tbulding as a code owner January 6, 2022 15:17
@@ -50,7 +49,6 @@ Metadata:
default: Quick Start S3 bucket name
QSS3KeyPrefix:
default: Quick Start S3 key prefix
cfn-lint: { config: { ignore_checks: [E9007] } }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add this back.

@andrew-glenn
Copy link
Contributor

A note for future-self:

Serverless transformations insert a lambda basic execution rule with a hard-coded ARN (arn:aws). Until we can find a way to either modify the transformed template in the middle of CFN-Linting's workflow, the only path forward is a global exclude.

In the future, a resource -level exclude will propagate down to the generated resources, but that's pending the next release of the Serverless Application Model. See aws/serverless-application-model#2224

@tbulding tbulding marked this pull request as draft February 3, 2022 16:44
@tbulding tbulding marked this pull request as ready for review February 3, 2022 16:44
@tbulding tbulding merged commit 43ad035 into aws-quickstart:develop Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants