test(maintenance): Expose ResponseStream object to simplify testing in event handler #4753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
event-handler
svozza
force-pushed
the
httpstream-mock
branch
from
63dc452 to
7431b5f
Compare
svozza
commented
Nov 14, 2025
dreamorosi
reviewed
Nov 14, 2025
Contributor
dreamorosi
left a comment
dreamorosi
left a comment
There was a problem hiding this comment.
I've left a comment in the linked issue about the general idea of exporting this, however everything else already looks good 👍
svozza
force-pushed
the
httpstream-mock
branch
2 times, most recently
from
ea90f8b to
b5db916
Compare
svozza
force-pushed
the
httpstream-mock
branch
from
b5db916 to
6367a22
Compare
Contributor
Author
|
I've update the PR based on your feedback. |
dreamorosi
approved these changes
Nov 15, 2025
Contributor
dreamorosi
left a comment
dreamorosi
left a comment
There was a problem hiding this comment.
Thank you for the PR and for engaging in the discussion.
I've left a comment in this other issue to remind us to add details on how to test this feature to the docs.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the need for us to implement a custom response stream mock when testing handlers that use the
streamifyorresolveStreamfunctions.Changes
ResponseStreamclass that matches the actiual type used by lambda functions when streamingstreamifyResponsefunction to use theResponseStreamclassTesting
ResponseStreamclassMockResponseStreamclassIssue number: closes #4752
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.