feat(event-handler): add resolution logic to base router #4349
+851
−431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XXL
boring-cyborg
bot
added
event-handler
svozza
commented
Aug 16, 2025
| headers, | ||
| multiValueHeaders, | ||
| body: await response.text(), | ||
| isBase64Encoded: false, |
There was a problem hiding this comment.
I've hardcodedisBase64Encoded for now but we will need to figure out how to deal with this
| @@ -133,11 +139,49 @@ abstract class BaseRouter { | |||
| }; | |||
| } | |||
|
|
|||
| public abstract resolve( | |||
| public async resolve( | |||
There was a problem hiding this comment.
Now that this function has an implementation, there are no abstract methos remaining. Should BaseRouter still be an abstract class?
|
|
||
| try { | ||
| const request = proxyEventToWebRequest(event); | ||
| const path = new URL(request.url).pathname as Path; |
There was a problem hiding this comment.
In general, I dislike casting, should these two assignments use type guards?
svozza
force-pushed
the
event-handler/response-resolver-logic
branch
from
f5d5280 to
14a6f53
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the final resolution logic for the
BaseRouterclass. Theresolvemethod is no longer abstract and has a concrete implementation where it looks up the route registry using the path and tries to retirve a resolver for the route. If not route is found, we throw aNotFoundErroe. If any exceptions are thrown from the handler, these are caught and handled by the already existinghandleErrormethod.Changes
BaseRouterto have. oncrete implementation ofresolvemethodAPIGatewayProxyResulttype that lambda expectsresolvefunction is implemented in the base classthiscontext is preserved when using decorators.Issue number: closes #4142
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.