Skip to content

fix(metrics): revert changes when raise warning with overridden default dimensions #4226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025

Conversation

svozza
Copy link
Contributor

@svozza svozza commented Jul 29, 2025

Summary

The change in this PR has caused duplicate log messages to be created that are causing the e2e tests to fail. We will need to handle these duplicate logs appearing before we release the change as it will be confusing for customers.

Changes

Reverts #4222

Issue number: closes #4227


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added metrics This item relates to the Metrics Utility tests PRs that add or change tests labels Jul 29, 2025
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Jul 29, 2025
@svozza svozza requested a review from dreamorosi July 29, 2025 12:02
Copy link

Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @svozza pls open an issue and keep the acknowledge section in the PR body.

@leandrodamascena leandrodamascena added the do-not-merge This item should not be merged label Jul 29, 2025
@leandrodamascena leandrodamascena changed the title Revert "fix(metrics): emit warning when default dimensions are overwritten" fix(metrics): revert changes when raise warning with overridden default dimensions Jul 29, 2025
@svozza svozza requested a review from leandrodamascena July 29, 2025 12:35
@leandrodamascena leandrodamascena removed the do-not-merge This item should not be merged label Jul 29, 2025
@svozza svozza merged commit c9d6aa0 into main Jul 29, 2025
98 of 99 checks passed
@svozza svozza deleted the revert-4222-fix/warn-on-default-dimension-overwrite branch July 29, 2025 13:10
Copy link
Contributor

@aws-powertools/lambda-typescript No related issues found. Please ensure 'pending-release' label is applied before releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics This item relates to the Metrics Utility size/L PRs between 100-499 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Duplicate warning being logged when invoking the captureColdStartMetric in the Metrics utility
2 participants