fix(tracer): skip tracing CONNECT requests #4148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR fixes the bug described in the linked issue, which caused runtime errors when using the Tracer with requests being sent via a proxy using the
fetch
module. Moving forward, tracing of these requests will be skipped entirely and the only request that will appear in the trace data will be the one being proxied.This aligns with the Powertools for AWS Lambda (Python) and X-Ray SDK implementations, as well as what suggested by the customer reporting the bug in the linked issue.
While working on this PR I also removed some old unit tests that covered portions of code that were deprecated. These same lines are also now excluded from the coverage report.
Issue number: fixes #4114
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.