Skip to content

chore(commons): Remove eslint from commons pkg #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 28, 2021
Merged

chore(commons): Remove eslint from commons pkg #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25da012
Removed eslint from commons pkg
dreamorosi Dec 28, 2021
d6f54db
Fixed linting issues
dreamorosi Dec 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
231 changes: 0 additions & 231 deletions packages/commons/.eslintrc.json
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/commons/src/utils/lambda/LambdaInterface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Handler } from 'aws-lambda';

interface LambdaInterface {
handler: Handler;
handler: Handler
}

export {
Expand Down
12 changes: 6 additions & 6 deletions packages/commons/tests/unit/LambdaInterface.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Callback, Context, Handler } from 'aws-lambda';
import { Callback, Context } from 'aws-lambda';
import { ContextExamples, LambdaInterface } from '../../src';

describe('LambdaInterface', () => {
Expand All @@ -8,13 +8,13 @@ describe('LambdaInterface', () => {
// @ts-ignore
public handler<TEvent, TResult>(
_event: TEvent,
_context: Context,
context: Context,
_callback: Callback<TResult>,
): void | Promise<TResult> {
_context.done();
_context.fail(new Error('test Error'));
_context.succeed('test succeed');
_context.getRemainingTimeInMillis();
context.done();
context.fail(new Error('test Error'));
context.succeed('test succeed');
context.getRemainingTimeInMillis();
}
}

Expand Down