Skip to content

docs: typo for serverless framework #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Conversation

HaaLeo
Copy link
Contributor

@HaaLeo HaaLeo commented Sep 21, 2023

Description of your changes

According to the docs it should be {aws:region} Reference

Related issues, RFCs

Issue number: #1706

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

According to the docs it should be {aws:region}
@HaaLeo HaaLeo requested a review from a team September 21, 2023 08:49
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Sep 21, 2023
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Sep 21, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 21, 2023

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #typescript channel on our Powertools for AWS Lambda Discord: Invite link

@github-actions
Copy link
Contributor

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further bug Something isn't working labels Sep 21, 2023
@am29d am29d requested review from am29d and removed request for a team September 21, 2023 10:10
Copy link
Contributor

@am29d am29d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR fixing the typo. I have added the issue #1706 .

We need also to adjust the update layer script here so we can update the layer version in the docs. Could you please change this file as well?

@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Sep 21, 2023
@HaaLeo
Copy link
Contributor Author

HaaLeo commented Sep 21, 2023

Hi @am29d, thx for creating the issue. I've updated the script as well.
You can review once more. :)

@HaaLeo HaaLeo requested a review from am29d September 21, 2023 10:57
Copy link
Contributor

@am29d am29d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HaaLeo for the PR 🙏 , closes #1706 .

@am29d am29d removed the bug Something isn't working label Sep 21, 2023
@am29d am29d changed the title fix: typo for serverless framework docs: typo for serverless framework Sep 21, 2023
@am29d am29d removed the need-issue This PR needs an issue before it can be reviewed/worked on further label Sep 21, 2023
@am29d
Copy link
Contributor

am29d commented Sep 21, 2023

Hey @HaaLeo , apologies for the merge conflict, I have approved the PR during a minor release and it changed the index.md during the layer version update. Can I ask you to resolve the conflict this last time, then we can merge it and update the docs (we can update docs outside of release cycle).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@HaaLeo
Copy link
Contributor Author

HaaLeo commented Sep 21, 2023

@am29d now it should be good to go

@am29d am29d merged commit c721d35 into aws-powertools:main Sep 21, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 21, 2023

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

@dreamorosi dreamorosi linked an issue Sep 21, 2023 that may be closed by this pull request
1 task
@dreamorosi dreamorosi removed the do-not-merge This item should not be merged label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation documentation Improvements or additions to documentation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: typo aws::region in serverless framework and terraform
3 participants