Skip to content

Docs: typo aws::region in serverless framework and terraform #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
am29d opened this issue Sep 21, 2023 · 2 comments · Fixed by #1701
Closed
1 task done

Docs: typo aws::region in serverless framework and terraform #1706

am29d opened this issue Sep 21, 2023 · 2 comments · Fixed by #1701
Assignees
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation

Comments

@am29d
Copy link
Contributor

am29d commented Sep 21, 2023

What were you searching in the docs?

The example of powertools with serverless framework has incorrect syntax for aws region variable:

functions:
  hello:
    handler: lambda_function.lambda_handler
    layers:
      - arn:aws:lambda:${aws::region}:094274105915:layer:AWSLambdaPowertoolsTypeScript:19

Keen in mind that we need to update the script in the workflow, so we can replace increment the layer version in the docs during release.

for pseudo_region in '{region}' '${AWS::Region}' '${aws::region}' '{aws::region}' '{env.region}' '${cdk.Stack.of(this).region}' '${aws.getRegionOutput().name}'; do

Is this related to an existing documentation section?

Getting started

How can we improve?

Review all the `aws::region` variables, including terraform.

Got a suggestion in mind?

No response

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@am29d am29d added documentation Improvements or additions to documentation triage This item has not been triaged by a maintainer, please wait labels Sep 21, 2023
@am29d am29d added confirmed The scope is clear, ready for implementation and removed triage This item has not been triaged by a maintainer, please wait labels Sep 21, 2023
@am29d am29d closed this as completed Sep 21, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi linked a pull request Sep 21, 2023 that will close this issue
9 tasks
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed confirmed The scope is clear, ready for implementation labels Sep 21, 2023
@dreamorosi
Copy link
Contributor

Issue title mentions Terraform but the linked PR doesn't change the content of that snippet. Was this on purpose or should we reopen the issue?

@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation
Projects
Development

Successfully merging a pull request may close this issue.

2 participants