Skip to content

chore(docs): Fix docs upload to s3 #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2023
Merged

chore(docs): Fix docs upload to s3 #1494

merged 1 commit into from
Jun 13, 2023

Conversation

sthulb
Copy link
Contributor

@sthulb sthulb commented Jun 12, 2023

Description of your changes

Related issues, RFCs

Issue number: #1490

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Jun 12, 2023
@pull-request-size pull-request-size bot added the size/M PR between 30-99 LOC label Jun 12, 2023
@github-actions github-actions bot added the bug Something isn't working label Jun 12, 2023
@dreamorosi dreamorosi changed the title fix(docs): Fix docs upload to s3 chore(docs): Fix docs upload to s3 Jun 13, 2023
@dreamorosi dreamorosi merged commit 8b5c60f into main Jun 13, 2023
@dreamorosi dreamorosi deleted the docs-s3-revert-revert branch June 13, 2023 15:57
@dreamorosi dreamorosi linked an issue Jun 13, 2023 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation bug Something isn't working size/M PR between 30-99 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: fix beta docs publishing
2 participants