Skip to content

chore(tests): restore parameter in e2eUtils #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

As documented in the linked issue, when adding the integration tests to the Idempotency utility we mistakenly introduced a bug in the e2eUtils module that caused the invocation payload to be discarded when invoking the functions deployed as part of the integration test sequentially.

This PR fixes the issue by tweaking the function to support both sequential and parallel invocations. Once merged the PR will close #1488.

Related issues, RFCs

Issue number: #1488

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Jun 9, 2023
@boring-cyborg boring-cyborg bot added the tests PRs that add or change tests label Jun 9, 2023
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Jun 9, 2023
@dreamorosi
Copy link
Contributor Author

Merging after confirming the fix, see successful run here.

@dreamorosi dreamorosi merged commit bb0b354 into main Jun 9, 2023
@dreamorosi dreamorosi deleted the dreamorosi/issue1488 branch June 9, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS PR between 0-9 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: e2e test ignore parameters used to invoke Lambda
1 participant