Skip to content

chore: updated homepage field in package.json files #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

As discussed in the linked issue, the package.json files of most all the utilities except Parameters had a wrong value in the homepage field which caused a 404 when users clicked on the rendered link on npm.

This PR fixes the url pointing it to the correct branch and resolves #1337.

How to verify this change

Check the diff. The new link will be available on npm on the next release.

Related issues, RFCs

Issue number: #1337

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi self-assigned this Feb 26, 2023
@dreamorosi dreamorosi linked an issue Feb 26, 2023 that may be closed by this pull request
2 tasks
@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label Feb 26, 2023
@github-actions github-actions bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Feb 26, 2023
@dreamorosi dreamorosi merged commit d28582f into main Feb 26, 2023
@dreamorosi dreamorosi deleted the 1337-maintenance-review-homepage-field-in-packagejson-files branch February 26, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/S PR between 10-29 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: review homepage field in package.json files
1 participant