-
Notifications
You must be signed in to change notification settings - Fork 162
Closed
Labels
automationThis item relates to automationThis item relates to automationcompletedThis item is complete and has been merged/shippedThis item is complete and has been merged/shippedinternalPRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Milestone
Description
Bug description
On lerna version
(https://github.com/awslabs/aws-lambda-powertools-typescript/blob/main/.github/workflows/on-release-prod.yml#L44) lerna bump all packages to new version in package.json
and package-lock.json
but bump as well @aws-lambda-powertools/commons
in our module package (https://github.com/awslabs/aws-lambda-powertools-typescript/blob/main/packages/metrics/package.json#L87) event with put strict version due this lerna/lerna#2326 .
Expected Behavior
I would expect lerna to not touch my dependencies or at least update package-lock.json properly ....
Current Behavior
lerna bump dependencies as well
Possible Solution
Not sure yet
Steps to Reproduce
run npx lerna version --conventional-commits --conventional-graduate --force-publish=* --yes --no-git-tag-version --no-push
npm run lerna-ci
will fail
Environment
- Powertools version used: 0.3.0
- Packaging format (Layers, npm): -
- AWS Lambda function runtime: -
- Debugging logs:
➜ aws-lambda-powertools-typescript git:(main) npm run lerna-ci
> [email protected] lerna-ci
> lerna exec -- npm ci
lerna notice cli v4.0.0
lerna info Executing command in 4 packages: "npm ci"
npm WARN prepare removing existing node_modules/ before installation
> @aws-lambda-powertools/[email protected] prepare /Users/chazalf/amazon/PowerTool/aws-lambda-powertools-typescript/packages/commons
> npm run build
> @aws-lambda-powertools/[email protected] build /Users/chazalf/amazon/PowerTool/aws-lambda-powertools-typescript/packages/commons
> tsc
added 574 packages in 13.871s
npm WARN prepare removing existing node_modules/ before installation
npm WARN prepare removing existing node_modules/ before installation
npm WARN prepare removing existing node_modules/ before installation
npm ERR! cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
Metadata
Metadata
Assignees
Labels
automationThis item relates to automationThis item relates to automationcompletedThis item is complete and has been merged/shippedThis item is complete and has been merged/shippedinternalPRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)