Skip to content

Maintenance: review and restore PR automation #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
dreamorosi opened this issue Jan 16, 2024 · 2 comments · Fixed by #1979
Closed
1 of 2 tasks

Maintenance: review and restore PR automation #1925

dreamorosi opened this issue Jan 16, 2024 · 2 comments · Fixed by #1979
Assignees
@dreamorosi
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

Summary

As a result of the work done in #1799 some of the automation related to PRs is broken and is no longer running.

For example, the workflow that is expected to run when a new PR is opened is failing due to permission issues:
https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/7540911226

Why is this needed?

So that workflows related to the PRs is automated as it was before.

Which area does this relate to?

Automation

Solution

We should review the workflows and related permissions so that they run as intended.

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.
@dreamorosi dreamorosi added triage This item has not been triaged by a maintainer, please wait internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Jan 16, 2024
@dreamorosi dreamorosi moved this from Triage to Backlog in Powertools for AWS Lambda (TypeScript) Jan 16, 2024
@dreamorosi dreamorosi added automation This item relates to automation confirmed The scope is clear, ready for implementation and removed triage This item has not been triaged by a maintainer, please wait labels Jan 16, 2024
@dreamorosi dreamorosi self-assigned this Jan 29, 2024
@dreamorosi dreamorosi linked a pull request Jan 30, 2024 that will close this issue
chore(ci): refactor more workflows to scope permissions #1979
Merged
9 tasks
@dreamorosi
Copy link
Contributor Author

This was fixed with #1978 & #1979

@github-project-automation github-project-automation bot moved this from Backlog to Coming soon in Powertools for AWS Lambda (TypeScript) Jan 30, 2024
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Jan 30, 2024
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed confirmed The scope is clear, ready for implementation labels Jan 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamorosi dreamorosi

Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
Powertools for AWS Lambda (TypeScript)
Status: Shipped
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ci): refactor more workflows to scope permissions aws-powertools/powertools-lambda-typescript
1 participant
@dreamorosi