Maintenance: npm script package is incorrect

[Muthuveerappanv]

Expected Behaviour

the main package.json has a script package.

Excepted behavior is that it will package the entire workspace.

Current Behaviour

Currently it goes in a recursive loop

> [email protected] package
> npm run package


> [email protected] package
> npm run package


> [email protected] package
> npm run package


> [email protected] package
> npm run package


> [email protected] package
> npm run package

Code snippet

npm run package

Steps to Reproduce

on the root directory of aws-lambda-powertools-typescript

run

npm install
npm run package

Possible Solution

No response

AWS Lambda Powertools for TypeScript version

latest

AWS Lambda function runtime

18.x

Packaging format used

npm

Execution logs

No response

[dreamorosi]

Hi Muthu, thank you for opening this issue.

You are right, in its current form the command is broken and causes a recursion. I think the issue went unnoticed because we don't really use the command as we use lerna to package (for now) and all other commands that are run across the workspace in our CI are always ran with the proper flag to make more explicit what is being run.

I am also changing the categorization of the issue from bug to maintenance as the issue doesn't affect runtime behavior (read is this a bug?).

Nevertheless, I think for the time being we should fix this.

---

Note: I see that you have already opened a PR, thank you for the bias for action. Next time however, please consider waiting until one of the maintainers has triaged the issue before moving onto a PR.
We try to follow the process described in the contributing guidelines (here) to make sure that issues have been discussed and their scope has been agreed upon to minimize the risk of investing time on a PR that might not be valid or not get the attention it deserves (in terms of reviews) on a timely manner. Appreciate your understanding!

[Muthuveerappanv]

Hi Muthu, thank you for opening this issue.

You are right, in its current form the command is broken and causes a recursion. I think the issue went unnoticed because we don't really use the command as we use lerna to package (for now) and all other commands that are run across the workspace in our CI are always ran with the proper flag to make more explicit what is being run.

I am also changing the categorization of the issue from bug to maintenance as the issue doesn't affect runtime behavior (read is this a bug?).

Nevertheless, I think for the time being we should fix this.

Note: I see that you have already opened a PR, thank you for the bias for action. Next time however, please consider waiting until one of the maintainers has triaged the issue before moving onto a PR. We try to follow the process described in the contributing guidelines (here) to make sure that issues have been discussed and their scope has been agreed upon to minimize the risk of investing time on a PR that might not be valid or not get the attention it deserves (in terms of reviews) on a timely manner. Appreciate your understanding!

Thank you @dreamorosi, and appreciate the explanation of the PR & Issue process, point noted 👍
Will follow the same in the Issues & PRs to come!

[dreamorosi]

Thank you for understanding and again, appreciate the help!

PR looks good now, I have approved it and will merge it later today.

[github-actions]

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.