Skip to content

docs: Readme update #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2020
Merged

docs: Readme update #72

merged 2 commits into from
Sep 1, 2020

Conversation

pankajagrawal16
Copy link
Contributor

@pankajagrawal16 pankajagrawal16 commented Sep 1, 2020 •
edited
Loading

Issue #, if available:

Description of changes:

Improvements to read me.

  • Remove feature setup instruction from readme since its present on documentation site.
  • Refer to example application in readme.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

msailes
msailes approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@msailes msailes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@pankajagrawal16 pankajagrawal16 merged commit e1ddebe into master Sep 1, 2020
@pankajagrawal16 pankajagrawal16 deleted the readme-update branch September 1, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msailes msailes msailes approved these changes

@stevehouel stevehouel Awaiting requested review from stevehouel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pankajagrawal16 @msailes