-
Notifications
You must be signed in to change notification settings - Fork 93
chore(ci): Make E2E tests compatible with latest CDK lib version. Improve retry implementation. #2008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version. Refactor retry4j to resilience4j.
2 tasks
|
E2E tests pass including Tracing E2E Test for both JVM and GraalVM. https://github.com/aws-powertools/powertools-lambda-java/actions/runs/16754244700 |
dreamorosi
approved these changes
Aug 6, 2025
2 tasks
This was referenced Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue introduced by a CDK lib update (#1990). This issue was caused by an update to the JSON structure in the
*.assets.json
generated files that we read to determine the deployment S3 bucket for asset upload in our E2E tests.Additionally, this PR improves the retry logic across all E2E tests by refactoring from the deprecated retry4j to resilience4j and removing all unnecessary
Thread.sleep
logic. This will speed up the E2E test duration as well.Side note: I will keep an eye on TracingE2ET (related issue #1846). Potentially, this issue was caused by sleeping too long in the old retry logic.
This PR also introduces GraalVM support for the re-enabled TracingE2ET.
Changes
Issue number: #2007, #1846
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.