Skip to content

(internal) GitHub build fails when using git-revision-date plugin in mkdocs #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeromevdl opened this issue Apr 29, 2022 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@jeromevdl
Copy link
Contributor

jeromevdl commented Apr 29, 2022

After the apparition of a cve and a correction pushed by git, we had an error when building the doc:

Error: fatal: unsafe repository ('/docs' is owned by someone else)

A git command (git log -n 1 --date=short) is issued by the git-revision-date plugin (see here) within the mkdocs container and we cannot apply the workaround git config --global --add safe.directory ... in the container.

We are removing the plugin temporarily (#853) to make the build work.

Expected Behavior

Using the plugin should work (the git log command performed by the plugin should not failed)

Current Behavior

The git command issued by the plugin fails.

Possible Solution

Steps to Reproduce (for bugs)

  • Add the plugin git-revision-date in mkdocs.yml
  • Let Github Actions run the build
@jeromevdl jeromevdl added the bug Something isn't working label Apr 29, 2022
@jeromevdl jeromevdl changed the title (internal) Build fails when using git-revision-date plugin in mkdocs (internal) GitHub build fails when using git-revision-date plugin in mkdocs Apr 29, 2022
@msailes
Copy link
Contributor

msailes commented Feb 19, 2023

@rubenfonseca, @heitorlessa Python seems to be using this plugin without any issues. Was this a problem for you? Did you have to do anything to fix it?

@msailes msailes removed the triage label Feb 19, 2023
@heitorlessa
Copy link
Contributor

You have to install it, here's our Dockerfile so make docs-local-docker and make build-docs-website work: https://github.com/awslabs/aws-lambda-powertools-python/blob/develop/docs/Dockerfile#L2

@jeromevdl
Copy link
Contributor Author

closed with #1066

@machafer machafer moved this from Working on it to Shipped in AWS Lambda Powertools for Java Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants