-
Notifications
You must be signed in to change notification settings - Fork 33
feat(tracing): add Subsegment wrapper to prevent exposing Amazon.XRayRecorder.Core.Internal #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat(tracing): add Subsegment wrapper to prevent exposing Amazon.XRayRecorder.Core.Internal #950
Conversation
….Recorder.Core.Internal
….Recorder.Core.Internal
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Hey, @hjgraca! I tried implementing it this way. Please, tell me your thoughts! If there's anything you think might need changes or you believe another approach is better, let me know! |
Hi @JonkaSusaki, thank you so much for working on this PR! We will review this PR as soon as possible and provide feedback. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #950 +/- ##
===========================================
+ Coverage 77.47% 77.68% +0.20%
===========================================
Files 271 272 +1
Lines 10900 10902 +2
Branches 1287 1287
===========================================
+ Hits 8445 8469 +24
+ Misses 2041 2020 -21
+ Partials 414 413 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @JonkaSusaki , thank you so much for the pull request, and sorry for the slow response I have been away for the last 2 weeks. |
Hey @hjgraca . Thanks for the response! |
Hi @JonkaSusaki hope you are well, do you have an idea of when you have time to add the tests? |
…owertools-lambda-dotnet into tracing/subsegment-wrapper
Hello @hjgraca ,sorry for the delay. I added the tests. Thanks, and sorry again for the delay. |
Thank you @JonkaSusaki I just added a couple more tests to improve coverage. I will merge soon and this will be on the next release! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTM
|
Issue number: #603
Summary
Changes
This PR creates a wrapper to prevent exposing internal lib
Amazon.XRayRecorder
.libraries/src/AWS.Lambda.Powertools.Tracing/Internal/TracingSubsegment.cs
to place the wrapper;libraries/src/AWS.Lambda.Powertools.Tracing/Tracing.cs
to include the wrapper;User experience
Before the changes, users had to include the reference to
Amazon.XRay.Recorder.Core.Internal.Entities
to use theSubsegment
class. Now, theTracingSubsegment
was created and users can now import them using theAWS.Lambda.Powertools.Tracing.Internal
reference.Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
NO
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.