Skip to content

feat: Support Space CRD #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 16, 2025
Merged

feat: Support Space CRD #328

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d398a75
space feature
sirutBuasai Oct 10, 2025
58aa7d1
add tests
sirutBuasai Oct 10, 2025
9429e33
apply golang 1.25.0 and union field from code-gen
sirutBuasai Oct 10, 2025
cde3b1d
fix failure_reason string and remove resourcenotfound and resourcelim…
sirutBuasai Oct 11, 2025
6dcc3f6
revert failure reason change
sirutBuasai Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions apis/v1alpha1/ack-generate-metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ack_generate_info:
build_date: "2025-10-10T18:41:09Z"
build_hash: 37562000612658e62686882f1b4b924049d1e38c
go_version: go1.24.7
version: v0.52.0-5-g3756200
api_directory_checksum: 5ec38038727f738df3c51c7e9983d3cae9c2424a
build_date: "2025-10-10T22:06:00Z"
build_hash: eaabefb6bd7b2be8a1baf4478f22b3310e6921c8
go_version: go1.25.2
version: v0.52.0-6-geaabefb
api_directory_checksum: cdae97bbaa2ee28d0f130fa6ce3a7dfbf6393d1b
api_version: v1alpha1
aws_sdk_go_version: v1.39.2
generator_config_info:
file_checksum: b3f328f3032ea0472327663d5e3ff0faea76f05d
file_checksum: a83bafd2ca4591fa6783a3408a6cb430d1f036e1
original_file_name: generator.yaml
last_modification:
reason: API generation
5 changes: 5 additions & 0 deletions apis/v1alpha1/app.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions apis/v1alpha1/domain.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions apis/v1alpha1/enums.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

65 changes: 59 additions & 6 deletions apis/v1alpha1/generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,6 +931,64 @@ resources:
Tags:
compare:
is_ignored: true
Space:
exceptions:
errors:
404:
code: ResourceNotFound
terminal_codes:
- ResourceNotFound
- ResourceLimitExceeded
- InvalidParameterCombination
- InvalidParameterValue
- MissingParameter
hooks:
sdk_read_one_post_set_output:
code: rm.customDescribeSpaceSetOutput(ko)
sdk_update_pre_build_request:
template_path: common/sdk_update_pre_build_request.go.tpl
sdk_delete_pre_build_request:
template_path: common/sdk_delete_pre_build_request.go.tpl
sdk_delete_post_request:
template_path: common/sdk_delete_post_request.go.tpl
fields:
OwnershipSettings:
is_immutable: true
SpaceSharingSettings:
is_immutable: true
Status:
is_read_only: true
print:
name: STATUS
from:
operation: DescribeSpace
path: Status
FailureReason:
is_read_only: true
print:
name: FAILURE-REASON
priority: 1
from:
operation: DescribeSpace
path: FailureReason
HomeEfsFileSystemUid:
is_read_only: true
from:
operation: DescribeSpace
path: HomeEfsFileSystemUid
CreationTime:
is_read_only: true
from:
operation: DescribeSpace
path: CreationTime
Url:
is_read_only: true
from:
operation: DescribeSpace
path: Url
Tags:
compare:
is_ignored: true
Comment on lines +987 to +989
Copy link
Member

@michaelhtm michaelhtm Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ignore Tags compare?

Copy link
Member Author

@sirutBuasai sirutBuasai Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all sagemaker resources, we haven't implemented tag comparison/updates yet. I'm not sure if this has been done upstream from codegen already. But if it has, we'll probably require another PR that enable tag comparison across all resources.

TrainingJob:
reconcile:
requeue_on_success_seconds: 300
Expand Down Expand Up @@ -1181,7 +1239,7 @@ ignore:
- PresignedMlflowTrackingServerUrl
# - ProcessingJob
- Project
- Space
# - Space
- StudioLifecycleConfig
# - TrainingJob
- TrainingPlan
Expand All @@ -1205,10 +1263,7 @@ ignore:
- DisableProfiler
- BatchTransformInput_
- MonitoringParquetDatasetFormat
- SpaceName
- DefaultSpaceSettings
- BatchDataCaptureConfig
- CodeRepositories
Copy link
Member

@michaelhtm michaelhtm Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be part of separate PR? it seems unrelated

Copy link
Member Author

@sirutBuasai sirutBuasai Oct 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so Space integrates with other SageMaker resources as part of SageMaker Unified Studio feature. This includes, App, Domain, Space, and UserProfile. All of these resources contain SpaceName, DefaultSapceSettings, and CodeRepositories. I've tested these features and they should be good to uncomment

- TableFormat
- RandomSeed
- TrainingImageConfig
Expand Down Expand Up @@ -1254,5 +1309,3 @@ ignore:
- AdditionalS3DataSource.ETag
- ModelPackageContainerDefinition.ModelDataETag
- SourceAlgorithm.ModelDataETag
- CustomFileSystemConfig.FSxLustreFileSystemConfig
- CustomFileSystemConfig.S3FileSystemConfig
Comment on lines -1257 to -1258
Copy link
Member

@michaelhtm michaelhtm Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one as well

Copy link
Member Author

@sirutBuasai sirutBuasai Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old SDK version that was pinned to 1.32 had only CustomFileSystemConfig.EFSFileSystemConfig. Upgrade to SDK 1.39 added these two additional union fields. This field is used in Space, Domain, and UserSetting so they should be added.

120 changes: 120 additions & 0 deletions apis/v1alpha1/space.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading