Create shallow canary marker #240
Conversation
Add placeholder values in replacement_values.py to avoid KeyError
rd-pong
requested review from
ananth102
and removed request for
jljaco and
surajkota
|
|
||
|
|
||
| @service_marker | ||
| @pytest.mark.shallow_canary |
There was a problem hiding this comment.
This marker means if we run pytest with this marker then run this test. In your shell-script you are still running these tests with the regions in this ^(eu-south-2|ap-southeast-3|me-central-1|eu-central-2) Correct if I'm wrong but isn't the goal of this pr to not run these tests in those regions since image is missing?
There was a problem hiding this comment.
We want to run shallow canary, which includes training and hosting, in eu-south-2, ap-southeast-3, me-central-1, eu-central-2. Training and hosting does not require missing images such as xgboost, debugger and clarify.
|
Verified shallow canary if-else logic (run_test.sh) in CodeBuild. If service region is one of the four (eu-south-2, ap-southeast-3, me-central-1, eu-central-2), then run test_endpoint, test_endpoint_config and test_trainingjob. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rd-pong, ryansteakley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- Create shallow canary marker for eu-south-2, ap-southeast-3, me-central-1, eu-central-2, since some registries are not available in those regions. - Add training and hosting to shallow canary - Add placeholder values in replacement_values.py to avoid KeyError (not found) Issue #, if available: Description of changes: By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
- Create shallow canary marker for eu-south-2, ap-southeast-3, me-central-1, eu-central-2, since some registries are not available in those regions. - Add training and hosting to shallow canary - Add placeholder values in replacement_values.py to avoid KeyError (not found) Issue #, if available: Description of changes: By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
2 participants
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.