Keep the desired code.s3* fields part of the spec
#43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AWS Lambda API doesn't return the original submitted `s3Bucket`, `s3Key` and `s3ObjectVersion` when a function is successfully created. Instead, it returns different values (In `Getfunction` Call) in a different response field (`Code.Location`). This is causing the generated code in ACK to set the `spec.Code.s3*` fields to nil values. To keep the experience in ACK lambda-controller consistent with the kubernetes exprience, we must keep the original submitted `code.S3*` fields part of the function's spec. This patch removes the part that is setting the `spec.Code.s3` to nil and allows the controllers to keep the original values part of the spec. Signed-off-by: Amine Hilaly <[email protected]>
a-hilaly
force-pushed
the
fields/spec.code
branch
from
39db935 to
551c6c3
Compare
|
/hold |
ack-bot
added
the
do-not-merge/hold
|
/unhold |
ack-bot
removed
the
do-not-merge/hold
|
/test lambda-unit-test |
jaypipes
approved these changes
Aug 14, 2022
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
michaelhtm
pushed a commit
to rushmash91/lambda-controller
that referenced
this pull request
Feb 5, 2025
…llers-k8s#43) ### Update to ACK runtime `v0.19.1`, code-generator `v0.19.1` ---------- * ACK code-generator `v0.19.1` [release notes](https://github.com/aws-controllers-k8s/code-generator/releases/tag/v0.19.1) * ACK runtime `v0.19.1` [release notes](https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.19.1) ---------- NOTE: This PR increments the release version of service controller from `v0.0.17` to `v0.0.18` Once this PR is merged, release `v0.0.18` will be automatically created for `mq-controller` **Please close this PR, if you do not want the new patch release for `mq-controller`** ---------- #### stdout for `make build-controller`: ``` building ack-generate ... ok. ==== building mq-controller ==== Copying common custom resource definitions into mq Building Kubernetes API objects for mq Generating deepcopy code for mq Generating custom resource definitions for mq Building service controller for mq Generating RBAC manifests for mq Running gofmt against generated code for mq Updating additional GitHub repository maintenance files ==== building mq-controller release artifacts ==== Building release artifacts for mq-v0.0.18 Generating common custom resource definitions Generating custom resource definitions for mq Generating RBAC manifests for mq ``` ---------- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes aws-controllers-k8s/community#1402
The AWS Lambda API doesn't return the original submitted
s3Bucket,s3Key, ands3ObjectVersionwhen a function is successfully created.Instead, it returns different values (In
Getfunctioncall) in adifferent response field (
Code.Location). This is causing thegenerated code in ACK to set the
spec.Code.s3*fields to nil values.To keep the experience in ACK lambda-controller consistent in the
Kubernetes-land, we must keep the original submitted
code.S3*fieldspart of the function's spec.
This patch removes the part that is setting the
spec.Code.s3*to niland allows the controllers to keep the original values part of the spec.
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Signed-off-by: Amine Hilaly [email protected]