fix: add a Describe call with filters before readOne if ID not populated #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelhtm
reviewed
Sep 12, 2025
Comment on lines
+753
to
+754
| sdk_read_many_pre_build_request: | ||
| template_path: hooks/security_group/sdk_read_many_pre_build_request.go.tpl |
Member
There was a problem hiding this comment.
can we use something like this instead? maybe a future improvement
https://github.com/aws-controllers-k8s/applicationautoscaling-controller/blob/main/generator.yaml#L18-L19
Member
There was a problem hiding this comment.
Yep probably a future improvement for all the CRDs using this technique.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes aws-controllers-k8s/community#2561
Description of changes:
Controller assumes a security group does not exist if the
Status.IDis empty. During adoption, users might want to adopt the resource by its name, as the ID is not trivial to guess (the security group ID is generated by AWS).These changes are adding one API call only when the
Status.IDis empty. Here we would make a singleDescribeSecurityGroupscall filtering bynameandVPC ID, and populate the resource ID, to be used in subsequent API calls.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.