Skip to content

Conversation

knottnt
Copy link
Contributor

@knottnt knottnt commented Aug 14, 2025

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler August 14, 2025 18:14
@ack-prow ack-prow bot added the approved label Aug 14, 2025
@knottnt knottnt added the version/minor Indicates downstream controller releases should bump the minor version. label Aug 14, 2025
@michaelhtm
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2025
Copy link

ack-prow bot commented Aug 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knottnt, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knottnt
Copy link
Contributor Author

knottnt commented Aug 14, 2025

/retest

Copy link

ack-prow bot commented Aug 14, 2025

@knottnt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 9a346a1 link false /test verify-attribution
s3-olm-test 9a346a1 link false /test s3-olm-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knottnt
Copy link
Contributor Author

knottnt commented Aug 14, 2025

/test eks-controller-test

@ack-prow ack-prow bot merged commit b6df33f into aws-controllers-k8s:main Aug 14, 2025
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged. version/minor Indicates downstream controller releases should bump the minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants