Migrate ACK to AWS SDK GO V2 #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheeseandcereal
requested changes
Jan 14, 2025
michaelhtm
force-pushed
the
backer
branch
2 times, most recently
from
0b0d80e to
fde99b9
Compare
michaelhtm
force-pushed
the
backer
branch
2 times, most recently
from
65286bf to
18b54d9
Compare
…trollers-k8s#563) Description of changes: Since the aws-sdk-go repository will not be supported starting July 2025, we are moving it under our repository. Doing so will also make it easy to make any changes if needed, when we support aws-sdk-go-v2. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
The package loads the aws-sdk-v2 package into the V1 API struct, that is used throughout the code-generator Co-Authored-By: Rohit Kurdukar - Amazon <[email protected]>
Also removing the V1 model and doc files for
* Change templates to import from right path * Handle pointer/non pointer assignments
This is the draft before the final commit addressing some type conversion issues, secret reference issues
S3Control has shapes with members that have default value assigned, even though they are pointers. linked source from comment where aws-sdk-v2 repository removes those defaults to treat to ensure its generated/handled as a pointer
Since errors now have their own type, we will be generating a new way of verifying if a resource is not found by just checking if the type of error the find operation returns is the same type as the ResourceNotFoundException error for that operation
…tion details Handling terminal errors and notFound errors differently. In previous commit we were using the service defined exception structures. This method does not work for controllers such as s3 and s3control. With more tests, we will now be using the APIError type provided by aws/smithy-go. This interface is implemented by all service errors so we will just compare to its ErrorCode() as we've done with V1.
Interface go types are marked as union types in the sdk model. Handling the code-generation of this type with this commit, and adding unit tests for it as well.
This example was seen in ec2 model for VpcPeeringConnectionStateReasonCode
|
/retest |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@michaelhtm: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Nice! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Since
aws-sdk-gowill no longer be maintained after 07/31/2024.With this PR, we will be using the aws-sdk-go-v2 API models to generate
our controllers.
The changes are:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.