using go env GOARCH to detect system arch instead of uname #373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
uname
does not always match the friendly arch that operator-sdk, an example is that on a normal mac you getx86_64
which fails to download since operator-sdk is released asamd64
, there could be other examples as well.Other things I thought of, since we might not want to rely on
go env
and be tied to go-tools:uname -m | tr '[:upper:]' '[:lower:]' | sed 's/x86_64/amd64/g'
Let me know which approach would be best
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Signed-off-by: Adam D. Cornett [email protected]