Skip to content

Conversation

acornett21
Copy link
Contributor

Issue #, if available:
N/A

Description of changes:
uname does not always match the friendly arch that operator-sdk, an example is that on a normal mac you get x86_64 which fails to download since operator-sdk is released as amd64, there could be other examples as well.

Other things I thought of, since we might not want to rely on go env and be tied to go-tools:

  • uname -m | tr '[:upper:]' '[:lower:]' | sed 's/x86_64/amd64/g'
  • have this script take in arch as an arg

Let me know which approach would be best

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Adam D. Cornett [email protected]

…me doesn't work on all systems

Signed-off-by: Adam D. Cornett <[email protected]>
@ack-bot ack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 10, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Nov 10, 2022

Hi @acornett21. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Adam! the go env should be good.
/ok-to-test
/approve

@ack-bot ack-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 10, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Nov 10, 2022

@acornett21: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
s3-controller-test d670ceb link /test s3-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly
Copy link
Member

/retest
/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Nov 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, acornett21

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit a6a8a09 into aws-controllers-k8s:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants