Skip to content

Conversation

@Anorlondo448
Copy link
Contributor

Added a TASK existence check before checking the AWS CLI, because If the TASK specified in the second argument does not exist, the AWS CLI version upgrade message will be displayed.

$ bash check-ecs-exec.sh ecs-cluster-name aaaaaaaabbbbbbbbbbbbcccccccddddd
-------------------------------------------------------------
Prerequisites for check-ecs-exec.sh
-------------------------------------------------------------
  jq      | OK (~~~~)
  AWS CLI | OK (~~~~)
-------------------------------------------------------------
Prerequisites for the AWS CLI to use ECS Exec
-------------------------------------------------------------
Pre-flight check failed: ECS Exec requires the AWS CLI v1.19.28/v2.1.30 or later.
Please update the AWS CLI and try again?
  For v2: https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2.html
  For v1: https://docs.aws.amazon.com/cli/latest/userguide/install-cliv1.html

@Anorlondo448 Anorlondo448 force-pushed the add_taskdef_existence_check branch 2 times, most recently from b94f0ae to 4a30ac8 Compare March 28, 2021 03:43
@Anorlondo448
Copy link
Contributor Author

@toricls
Thank you for your comment!
Fixed the message.

@Anorlondo448 Anorlondo448 force-pushed the add_taskdef_existence_check branch from 4a30ac8 to c8cfd4a Compare March 28, 2021 04:52
@toricls
Copy link
Contributor

toricls commented Mar 28, 2021

Thanks for the contribution @Anorlondo448 🙌

@toricls toricls merged commit 974c2a0 into aws-containers:main Mar 28, 2021
@Anorlondo448 Anorlondo448 deleted the add_taskdef_existence_check branch March 28, 2021 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants