Skip to content

Fix display when EC2 or Task Role is not configured #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2021
Merged

Fix display when EC2 or Task Role is not configured #30

merged 1 commit into from
Jun 26, 2021

Conversation

@hi1280
Copy link
Contributor

@hi1280 hi1280 commented Jun 26, 2021

The results before and after the fix are as follows.

Before

$ ./check-ecs-exec.sh example fb2cd3c7074d4052912985dae174fa22
...
  EC2 or Task Role       | Not Configured  VPC Endpoints          | SKIPPED (vpc-07b899d4fb276ef4f - No additional VPC endpoints required)

After

$ ./check-ecs-exec.sh example fb2cd3c7074d4052912985dae174fa22
...
  EC2 or Task Role       | Not Configured
  VPC Endpoints          | SKIPPED (vpc-07b899d4fb276ef4f - No additional VPC endpoints required)

toricls
toricls approved these changes Jun 26, 2021
View reviewed changes
Copy link
Contributor

@toricls toricls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @hi1280!

@toricls toricls merged commit 81c776d into aws-containers:main Jun 26, 2021
@toricls toricls added the bug Something isn't working label Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@toricls toricls toricls approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hi1280 @toricls