Skip to content

Conversation

Brianwithay21
Copy link
Member

@Brianwithay21 Brianwithay21 commented May 17, 2022

Updated the initial guided-aws boilerplate code to use a real world example of verifying an S3 bucket's encryption

Related PR:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Brianwithay21 Brianwithay21 marked this pull request as ready for review May 19, 2022 23:07
}

@Test
public void handleRequest_nonCompliant() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this test case.

Copy link

@wkexiang wkexiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to confirm that those handlers should do the things as expected right? Have you performed any end-to-end tests?

@Brianwithay21
Copy link
Member Author

Just want to confirm that those handlers should do the things as expected right? Have you performed any end-to-end tests?

Yes, I built and registered the default boilerplate code and created a complaint stack and non-compliant stack. Both operations had the expected result

@wkexiang
Copy link

wkexiang commented May 26, 2022

Just want to confirm that those handlers should do the things as expected right? Have you performed any end-to-end tests?

Yes, I built and registered the default boilerplate code and created a complaint stack and non-compliant stack. Both operations had the expected result

Got it. Thanks for confirming

@wkexiang wkexiang closed this May 26, 2022
@Brianwithay21 Brianwithay21 reopened this May 26, 2022
@Brianwithay21 Brianwithay21 merged commit d4fd647 into aws-cloudformation:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants