Return AccessDenied Error Code when failing to decrypt credentials #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
HOOKtypes, credentials are encrypted service side before invoking the hook. Credentials are decrypted while setting up the runtime before calling the authored handler code.Sometimes decryption of the credentials fails when customer is missing permissions for decrypting the credentials. This usually happens when customer specifies their own hook execution role.
To avoid this being marked as an
InternalFailureservice side, having the Hook wrapper return anAccessDeniederror code instead back to CFN whenever decryption of credentials failsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.