Skip to content

added generic type for multiple type support #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2020
Merged

added generic type for multiple type support #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ce8804
added generic type for multiple type support
ammokhov Jun 12, 2020
ce84b50
added MULTIPLE container type
ammokhov Jun 13, 2020
dcb3456
simplified translate type method
ammokhov Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions python/rpdk/java/resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ def translate_type(resolved_type):
if resolved_type.container == ContainerType.PRIMITIVE:
return PRIMITIVE_TYPES[resolved_type.type]

if resolved_type.container == ContainerType.MULTIPLE:
return "Object"

item_type = translate_type(resolved_type.type)

if resolved_type.container == ContainerType.DICT:
Expand Down
6 changes: 5 additions & 1 deletion tests/test_resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import pytest
from rpdk.core.jsonutils.resolver import ContainerType, ResolvedType
from rpdk.core.jsonutils.resolver import MULTIPLE, ContainerType, ResolvedType
from rpdk.java.resolver import PRIMITIVE_TYPES, translate_type

RESOLVED_TYPES = [
Expand All @@ -25,6 +25,10 @@ def test_translate_type_dict(resolved_type, native_type):
assert traslated == f"Map<String, {native_type}>"


def test_translate_type_multiple():
assert translate_type(ResolvedType(ContainerType.MULTIPLE, MULTIPLE)) == "Object"


@pytest.mark.parametrize("resolved_type,native_type", RESOLVED_TYPES)
def test_translate_type_list(resolved_type, native_type):
traslated = translate_type(ResolvedType(ContainerType.LIST, resolved_type))
Expand Down