chore(test): added mfa selection in sms mfa required test #6141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the preferred option
…red and forego selection of mfa type upon sign in
ekjotmultani
changed the title
tyllark
approved these changes
May 14, 2025
| username: username, | ||
| password: password, | ||
| ); | ||
| // as of May 2025, cognito has stopped defaulting to sms mfa and now asks for mfa type selection in the normal flow |
There was a problem hiding this comment.
We can safely remove this comment as we are removing any remnants of the previously flow with this change. We can include this in the commit message though.
ekjotmultani
changed the title
ekjotmultani
changed the title
ekjotmultani
changed the title
tyllark
pushed a commit
that referenced
this pull request
May 15, 2025
…6141) * changed mfa preference flow for verifying if we can set sms as preferred and forego selection of mfa type upon sign in * removed duplicate test and changed "because" clause of test * changed test text to properly reflect the flow of the test
tyllark
pushed a commit
that referenced
this pull request
May 28, 2025
…6141) * changed mfa preference flow for verifying if we can set sms as preferred and forego selection of mfa type upon sign in * removed duplicate test and changed "because" clause of test * changed test text to properly reflect the flow of the test
tyllark
pushed a commit
that referenced
this pull request
May 29, 2025
…6141) * changed mfa preference flow for verifying if we can set sms as preferred and forego selection of mfa type upon sign in * removed duplicate test and changed "because" clause of test * changed test text to properly reflect the flow of the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Cognito now requires selection of MFA type as an auth step if both sms and email are enabled, updating our sms + email test to reflect these changes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.