feat: api for adopted table during gen1 -> gen2 migration #3040
+106
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 21223d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
iankhou
commented
Oct 30, 2025
Comment on lines
+165
to
+170
| if (shouldAdoptExistingTable) { | ||
| return AmplifyDataDefinition.fromString(schema, { | ||
| ...ADOPTED_DYNAMO_DATA_SOURCE_STRATEGY, | ||
| tableName: importedTableName, | ||
| } as unknown as ModelDataSourceStrategy); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is the important part.
iankhou
commented
Oct 30, 2025
Comment on lines
+75
to
+80
| // Adopted strategy where Amplify will synthesize a managed CFN table resource | ||
| const ADOPTED_DYNAMO_DATA_SOURCE_STRATEGY = { | ||
| dbType: 'DYNAMODB', | ||
| provisionStrategy: 'ADOPTED_AMPLIFY_TABLE', | ||
| } as const; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This is the important part.
iankhou
force-pushed
the
iankhou-adopted-table-api
branch
from
d180225 to
21223d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Issue number, if available:
Changes
Corresponding docs PR, if applicable:
Validation
Checklist
run-e2elabel set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.