This repository was archived by the owner on Sep 2, 2018. It is now read-only.
WIP: [RegAllocGreedy] Attempt to split unspillable live intervals #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanmckay
changed the title
|
I want to have this upstreamed and go through the normal LLVM review process. This PR is mostly for visibility. |
dylanmckay
force-pushed
the
fix-issue-1
branch
from
8d029db to
93d986a
Compare
Previously, when allocating unspillable live ranges, we would never attempt to split. We would always bail out and try last ditch graph recoloring. This patch changes this by attempting to split all live intervals before performing recoloring.
dylanmckay
force-pushed
the
fix-issue-1
branch
from
93d986a to
9933a17
Compare
|
This passes all tests in the LLVM suite. I will upstream now. |
|
I think that this is okay to merge. It causes no regressions in our code or LLVMs test suite. Even if it didn't get upstreamed, it's still a better fix than the one we currently have. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when allocating unspillable live ranges, we would never
attempt to split. We would always bail out and try last ditch graph
recoloring.
This patch changes this by attempting to split all live intervals before
performing recoloring.
This fixes issue #1