Skip to content

Upgrade to npm 8 and remove backwards-compatible lockfile #2867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2021
Merged

Upgrade to npm 8 and remove backwards-compatible lockfile #2867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ed18d0
Upgrade to npm 8 and remove backwards compatible lockfile
novemberborn Oct 17, 2021
14a57d1
During CI, remove .npmrc file since with the wrong npm version setup-…
novemberborn Oct 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,13 @@ jobs:
run: |
git config core.symlinks true
git reset --hard
- run: rm .npmrc
- uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}
cache: npm
- name: Upgrade npm
run: npm install --global npm@7
run: npm install --global npm@^8.1.2
- run: npm install --no-audit
- run: npm run cover
- uses: codecov/codecov-action@v2
Expand All @@ -45,12 +46,13 @@ jobs:
ts-version: [~4.4]
steps:
- uses: actions/checkout@v2
- run: rm .npmrc
- uses: actions/setup-node@v2
with:
node-version: ^12.22
cache: npm
- name: Upgrade npm
run: npm install --global npm@7
run: npm install --global npm@^8.1.2
- run: npm install --no-audit
- run: npm i typescript@${TS_VERSION}
env:
Expand All @@ -63,13 +65,14 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- run: rm .npmrc
- uses: actions/setup-node@v2
with:
node-version: ^12.22
cache: npm
- name: Upgrade npm
run: if [[ "$(npm -v)" != "7.23" ]]; then npm install --global npm@7.23; fi
- run: npm install --no-audit
run: if [[ "$(npm -v)" != "8.1.2" ]]; then npm install --global npm@8.1.2; fi
- run: npm install --no-audit --lockfile-version=3
- name: Test package-lock for unexpected modifications
run: |
npm -v
Expand All @@ -85,11 +88,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- run: rm .npmrc
- uses: actions/setup-node@v2
with:
node-version: ^12.22
- name: Upgrade npm
run: npm install --global npm@7
run: npm install --global npm@^8.1.2
- run: npm install --no-shrinkwrap --no-audit
- run: npm run cover

Expand All @@ -98,11 +102,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- run: rm .npmrc
- uses: actions/setup-node@v2
with:
node-version: ^16.4
cache: npm
- name: Upgrade npm
run: npm install --global npm@7
run: npm install --global npm@^8.1.2
- run: npm install --no-audit
- run: npx xo
1 change: 1 addition & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
lockfile-version=3
Loading