Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions lib/assert.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function formatWithLabel(label, value) {
}

class AssertionError extends Error {
constructor(opts) {
constructor(opts, raw) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I meant passing raw as a property in opts.

super(opts.message || '');
this.name = 'AssertionError';

Expand All @@ -39,6 +39,11 @@ class AssertionError extends Error {
this.operator = opts.operator;
this.values = opts.values || [];

// Raw expected and actual objects are stored for custom reporters
// (such as wallaby.js), that manage worker processes directly and
// use the values for custom diff views
this.raw = raw;

// Reserved for power-assert statements
this.statements = [];

Expand Down Expand Up @@ -87,7 +92,7 @@ function wrapAssertions(callbacks) {
assertion: 'is',
message,
values: [formatDescriptorDiff(actualDescriptor, expectedDescriptor)]
}));
}, {actual, expected}));
}
},

Expand All @@ -97,7 +102,7 @@ function wrapAssertions(callbacks) {
assertion: 'not',
message,
values: [formatWithLabel('Value is the same as:', actual)]
}));
}, {actual, expected}));
} else {
pass(this);
}
Expand All @@ -114,7 +119,7 @@ function wrapAssertions(callbacks) {
assertion: 'deepEqual',
message,
values: [formatDescriptorDiff(actualDescriptor, expectedDescriptor)]
}));
}, {actual, expected}));
}
},

Expand All @@ -126,7 +131,7 @@ function wrapAssertions(callbacks) {
assertion: 'notDeepEqual',
message,
values: [formatDescriptorWithLabel('Value is deeply equal:', actualDescriptor)]
}));
}, {actual, expected}));
} else {
pass(this);
}
Expand Down
17 changes: 16 additions & 1 deletion test/assert.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ function assertFailure(t, subset) {
t.is(lastFailure.message, subset.message);
t.is(lastFailure.name, 'AssertionError');
t.is(lastFailure.operator, subset.operator);
if (subset.raw) {
t.is(lastFailure.raw.expected, subset.raw.expected);
t.is(lastFailure.raw.actual, subset.raw.actual);
}
if (subset.statements) {
t.is(lastFailure.statements.length, subset.statements.length);
lastFailure.statements.forEach((s, i) => {
Expand Down Expand Up @@ -235,6 +239,7 @@ test('.is()', t => {
}, {
assertion: 'is',
message: '',
raw: {actual: 'foo', expected: 'bar'},
values: [
{label: 'Difference:', formatted: /- 'foo'\n\+ 'bar'/}
]
Expand All @@ -243,7 +248,9 @@ test('.is()', t => {
failsWith(t, () => {
assertions.is('foo', 42);
}, {
actual: 'foo',
assertion: 'is',
expected: 42,
message: '',
values: [
{label: 'Difference:', formatted: /- 'foo'\n\+ 42/}
Expand Down Expand Up @@ -301,6 +308,7 @@ test('.not()', t => {
}, {
assertion: 'not',
message: '',
raw: {actual: 'foo', expected: 'foo'},
values: [{label: 'Value is the same as:', formatted: /foo/}]
});

Expand Down Expand Up @@ -546,6 +554,7 @@ test('.deepEqual()', t => {
}, {
assertion: 'deepEqual',
message: '',
raw: {actual: 'foo', expected: 'bar'},
values: [{label: 'Difference:', formatted: /- 'foo'\n\+ 'bar'/}]
});

Expand All @@ -554,6 +563,7 @@ test('.deepEqual()', t => {
}, {
assertion: 'deepEqual',
message: '',
raw: {actual: 'foo', expected: 42},
values: [{label: 'Difference:', formatted: /- 'foo'\n\+ 42/}]
});

Expand All @@ -577,11 +587,16 @@ test('.notDeepEqual()', t => {
assertions.notDeepEqual(['a', 'b'], ['c', 'd']);
});

const actual = {a: 'a'};
const expected = {a: 'a'};
failsWith(t, () => {
assertions.notDeepEqual({a: 'a'}, {a: 'a'});
assertions.notDeepEqual(actual, expected);
}, {
actual,
assertion: 'notDeepEqual',
expected,
message: '',
raw: {actual, expected},
values: [{label: 'Value is deeply equal:', formatted: /.*\{.*\n.*a: 'a'/}]
});

Expand Down