-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Closed
Labels
bugcurrent functionality does not work as desiredcurrent functionality does not work as desiredgood for beginnerhelp wantedscope:assertions
Description
Infinity depth stack traces hardly seem necessary, but that is what we are currently doing.
#482 fixes that for t.plan(), which I think is important, since t.plan() generates a stack trace whether there is a test failure or not.
My remaining question is whether or not we should shorten them globally. I am not overly concerned about the performance impact of failing assertions, more so other libraries (like bluebird longStackTrace support) that might be creating overly long stacks and slowing things down.
Some investigation is needed here. If an Infinity value does not hurt the speed of a passing test suite, then let's leave it there. Otherwise we should bikeshed on how long it should be.
Metadata
Metadata
Assignees
Labels
bugcurrent functionality does not work as desiredcurrent functionality does not work as desiredgood for beginnerhelp wantedscope:assertions