Skip to content

Don't set global stack trace limit to be infinite #483

@jamestalmage

Description

@jamestalmage

Infinity depth stack traces hardly seem necessary, but that is what we are currently doing.
#482 fixes that for t.plan(), which I think is important, since t.plan() generates a stack trace whether there is a test failure or not.

My remaining question is whether or not we should shorten them globally. I am not overly concerned about the performance impact of failing assertions, more so other libraries (like bluebird longStackTrace support) that might be creating overly long stacks and slowing things down.

Some investigation is needed here. If an Infinity value does not hurt the speed of a passing test suite, then let's leave it there. Otherwise we should bikeshed on how long it should be.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions