use triedb config for reference root #1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
commented
Oct 16, 2024
darioush
commented
Oct 16, 2024
darioush
commented
Oct 16, 2024
darioush
commented
Oct 16, 2024
ARR4N
requested changes
Oct 16, 2024
darioush
commented
Oct 16, 2024
ceyonur
reviewed
Oct 16, 2024
ARR4N
previously approved these changes
Oct 17, 2024
darioush
commented
Oct 17, 2024
Signed-off-by: Darioush Jalali <[email protected]>
ARR4N
approved these changes
Oct 17, 2024
ceyonur
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This provides better alignment with upstream code, avoiding passing an extra boolean to statedb.Commit and avoids an additional triedb backend method.
Still considering whether we can avoid the concurrent use of the triedb ref. counting entirely
How this works
Removes UpdateAndReferenceRoot in favor of a triedb backend (hashdb) option that references root when Update is called.
How this was tested
CI
How is this documented
N/A