forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 4
feat: stateful precompiles + allowlist hooks #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d1da077
to
639aa1c
Compare
The allowlist hooks are included in this commit because they allow for the same functionality as stateful precompiles in `ava-labs/coreth` and `ava-labs/subnet-evm`.
bd8180b
to
e6840aa
Compare
darioush
approved these changes
Sep 9, 2024
Base automatically changed from
arr4n/libevm-precompile-overrides
to
arr4n/libevm
September 10, 2024 16:03
ARR4N
pushed a commit
that referenced
this pull request
Jul 13, 2025
…m#31081) This PR is #3 of a 3-part series that implements the new log index intended to replace core/bloombits. Based on ethereum#31079 and ethereum#31080 Replaces ethereum#30370 This part removes the old bloombits package and the chain indexer that was only used by bloombits. Deletes the old bloombits database. FilterMaps data structure explanation: https://gist.github.com/zsfelfoldi/a60795f9da7ae6422f28c7a34e02a07e Log index generator code overview: https://gist.github.com/zsfelfoldi/97105dff0b1a4f5ed557924a24b9b9e7 Search pattern matcher code overview: https://gist.github.com/zsfelfoldi/5981735641c956afb18065e84f8aff34 Note that the possibility of a tree hashing scheme and remote proof protocol are mentioned in the documents above but they are not exactly specified yet. These specs are WIP and will be finalized after the local log indexer/filter code is finalized and merged. --------- Co-authored-by: Felix Lange <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Introduces:
CanExecuteTransaction
andCanCreateContract
hooks (equivalent tosubnet-evm
allowlists).a. Although this makes for a larger PR than I'd have liked, I thought it was important to demonstrate how the equivalent
ava-labs/subnet-evm
functionality can be achieved.How this works
Hooks
CanExecuteTransaction()
is called fromcore.StateTransition.TransitionDb()
andCanCreateContract()
is called fromvm.EVM.create()
(the common path forEVM.Create()
andEVM.Create2()
). If they return nil then functionality continues as normal, otherwise their errors are propagated.Stateful precompiles
The PR introduces into
core/vm
:Note that the constructor returns the same interface as ordinary precompiles, allowing the returned value to use regular geth plumbing (including the existing
PrecompileOverride
hook). However, the concrete type that it returns has special-case handling when running precompiles.How this was tested
Both hooks result in unhappy paths when working correctly so their integration tests assert the equality of returned errors, which carry all externally injected arguments to demonstrate correct plumbing.
CanExecuteTransaction
is tested viacore.ApplyMessage()
whileCanCreateContract
is tested viaEVM.Create()
andEVM.Create2()
.Stateful precompiles have integration tests exercised via the
PrecompileOverride
hook andvm.EVM.Call()
, also demonstrating full plumbing of arguments.The
hookstest
package is introduced to simplify registration of hooks for testing.