chore(core/types): restructure libevm hooks code #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#133 is still a draft so it's too early to tell. I'll review this when I finish that work. Re rebasing, please never modify a branch that's prefixed with my username, unless via a PR into it that I review—it risks introducing conflicts that I'm not aware of. |
|
I definitely won't modify your branches 😄 Unless you tell me to |
Speaking of which, can I push to this branch please? I'll use it to abstract out the otherwise irrelevant refactoring in #133 then we can merge this and I'll merge |
|
Please merge #136 (into this branch) and then we can merge this into |
ARR4N
requested changes
Feb 13, 2025
ARR4N
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shamelessly taken from #133 such that #133 can be focused on its body x block hooking, and this PR can take care of the code movements, in order to have both PRs easier to review and git commit history/blame making more sense.
@ARR4N I'm happy to rebase your #133 if you want, let me know.