chore(core/rawdb): InspectDatabase can receive multiple times the same option
#132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
changed the title
InspectDatabase can receive multiple times the same option
ARR4N
approved these changes
Feb 12, 2025
ARR4N
added a commit
that referenced
this pull request
Feb 12, 2025
#132 (comment) Signed-off-by: Arran Schlosberg <[email protected]>
ARR4N
added a commit
that referenced
this pull request
Feb 12, 2025
Missed in earlier PR: #132 (comment) Signed-off-by: Arran Schlosberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drove me mad for a solid one minute in coreth where I tried to pass multiple times the option
WithDatabaseMetadataKeysbecause, I'm a bit of a fool let's face it, but, in order to make this... you guessed it, FOOLPROOF, this PR changes the code a tiny bit to support specifying each option more than once without overriding the previous option passed. The alternative would had been to add a comment on each option, but it feels more appropriate to resolve it with code directly.