Skip to content

fix(ci): module-renaming workflow includes .go.tpl and .proto #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

ARR4N
Copy link
Collaborator

@ARR4N ARR4N commented Feb 7, 2025

Why this should be merged

Introduction of breaking upstream changes (inclusion of .go.tpl files) since the workflow was written. Resulted in failed smoke tests due to ABI-binding templates not being updated.

How this works

Only (1) is necessary for the fix but the others were added for convenience as relevant to this PR:

  1. Replace module name in *.go.tpl files;
  2. As above for *.proto files (go_package option);
  3. Remove concurrency limitations as they're unnecessary with a manually triggered workflow; and
  4. Display all tags that point to the source commit as they're useful for inspection of version.

How this was tested

Successful workflow run at upstream v1.15.0.

For the modifications, respectively:

  1. Smoke tests pass and no .go.tpl files in Remnant references;
  2. As above re remnant references;
  3. N/A; and
  4. Inspection of step output.

@ARR4N ARR4N requested review from a team, darioush, qdm12 and ceyonur and removed request for a team February 7, 2025 12:27
@ARR4N ARR4N merged commit 761c4b4 into main Feb 7, 2025
6 of 7 checks passed
@ARR4N ARR4N deleted the arr4n/rename-module-templates branch February 7, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants