Skip to content

Commit 761c4b4

Browse files
authored
fix(ci): module-renaming workflow includes .go.tpl and .proto (#122)
## Why this should be merged Introduction of breaking upstream changes (inclusion of `.go.tpl` files) since the workflow was written. Resulted in [failed smoke tests](https://github.com/ava-labs/libevm/actions/runs/13198798601) due to ABI-binding templates not being updated. ## How this works Only (1) is necessary for the fix but the others were added for convenience as relevant to this PR: 1. Replace module name in `*.go.tpl` files; 2. As above for `*.proto` files (`go_package` option); 3. Remove concurrency limitations as they're unnecessary with a manually triggered workflow; and 4. Display all tags that point to the source commit as they're useful for inspection of version. ## How this was tested [Successful workflow run](https://github.com/ava-labs/libevm/actions/runs/13199663099/job/36848609786) at upstream v1.15.0. For the modifications, respectively: 1. Smoke tests pass and no `.go.tpl` files in [Remnant references](https://github.com/ava-labs/libevm/actions/runs/13199663099/job/36848609786#step:9:1); 2. As above re remnant references; 3. N/A; and 4. Inspection of [step output](https://github.com/ava-labs/libevm/actions/runs/13199663099/job/36848609786#step:6:5).
1 parent f906679 commit 761c4b4

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

.github/workflows/rename-module.yml

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@ on:
99
type: string
1010
default: "2bd6bd01d2e8561dd7fc21b631f4a34ac16627a1"
1111

12-
concurrency:
13-
group: ${{ github.workflow }}-${{ github.ref }}
14-
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
15-
1612
jobs:
1713
rename-module:
1814
runs-on: ubuntu-latest
@@ -32,14 +28,24 @@ jobs:
3228
echo "DEST_BRANCH=auto-rename-module_source-${{ inputs.source_commit }}_workflow-${WORKFLOW_HASH}-${{ github.ref_name }}" \
3329
>> "$GITHUB_OUTPUT";
3430
31+
- name: Fetch tags from ethereum/go-ethereum
32+
run: git fetch --tags https://github.com/ethereum/go-ethereum.git
33+
34+
- name: Tags pointing to source commit
35+
run: git tag --points-at ${{ inputs.source_commit }}
36+
3537
- name: Check out source commit
3638
run: git checkout ${{ inputs.source_commit }}
3739

3840
- name: Globally update module name
3941
run: |
4042
go mod edit -module github.com/ava-labs/libevm;
41-
find . -iname '*.go' -o -iname '*.txt' | xargs sed -i -E \
42-
's|(["`]github\.com/)ethereum/go-ethereum|\1ava-labs/libevm|g';
43+
find . \
44+
-iname '*.go' \
45+
-o -iname '*.txt' \
46+
-o -iname '*.go.tpl' \
47+
-o -iname '*.proto' | xargs \
48+
sed -i -E 's|(["`]github\.com/)ethereum/go-ethereum|\1ava-labs/libevm|g';
4349
4450
- name: Remnant references
4551
run: |

0 commit comments

Comments
 (0)