Add build information to the metrics/queries #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows use cases where we can see and query the changes in metrics after a version change in the code base. Ref: autometrics-dev/autometrics-rs#69 Ref: https://github.com/orgs/autometrics-dev/discussions/10
emschwartz
reviewed
Apr 21, 2023
mellowagain
reviewed
Apr 21, 2023
|
I'll add a recipe to modify the build information stuff within a dockerfile, it will make the PR significantly larger as the examples have not been set up to work with a build script (mostly to avoid issues with docker contexts) |
|
I'm also switching command line argument parsing a bit to use
The |
Breaking change: the long flags in autometrics now take the long form arguments starting with -- Also removes the unused `am-alertsgen` binary. Even though for the time being we are using sloth to generate the alerts, at some point we might want to change, and adding extra code/friction to do the change seems unwarranted for now.
6 tasks
emschwartz
reviewed
May 3, 2023
gagbo
commented
May 4, 2023
There is little reason to add a different name in the docs now that there is a single import again
emschwartz
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows use cases where we can see and query the changes in metrics
after a version change in the code base.
Ref: autometrics-dev/autometrics-rs#69
Ref: https://github.com/orgs/autometrics-dev/discussions/10