Add integration test for mobile run command with device ids #637
Conversation
xiankai
left a comment
xiankai
left a comment
There was a problem hiding this comment.
small reminder: need to fix lint as well
integration-test/src/commands.ts
Outdated
| "https://mobile-app.autify.com/projects/4yyFEL/test_plans/1EtZ0P"; | ||
| const mobileWorkspaceId = "4yyFEL"; | ||
| const mobileAndroidBuildId = "d1ulrD"; | ||
| const mobileDeviceIds = "R5CY23ND1KE"; |
There was a problem hiding this comment.
out of curiosity how did you arrive at this value? is it like your own device ID that you'll keep on during tests or something like a mock value?
There was a problem hiding this comment.
This is my own device ID value. This device ID should be in the "autify-cli" project so that we can record the actual API response. It means, if someone wants to update the recorded response, they will need to set their own local device temporarily :(
There was a problem hiding this comment.
I see, I guess it's unavoidable but at least having a one-line comment that this value needs to be replaced if we want to run any local device tests would help
We have no integration test with
--device-idsoption forautify mobile link startcommmand. This PR add the integration test and the network recording file.This test is also required for the Bitrise step autifyhq/bitrise-step-autify-test-run#12.