Skip to content

Force use_strict during testing #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2019
Merged

Force use_strict during testing #577

merged 2 commits into from
Feb 20, 2019

Conversation

lionello
Copy link
Contributor

Our project was using JS strict mode and we got errors like

TypeError: Cannot create property 'iat' on string

Enabling --use_strict during the mocha test revealed the culprit.

@lionello lionello mentioned this pull request Feb 15, 2019
Closed
@ziluvatar
Copy link
Contributor

ziluvatar commented Feb 18, 2019 •
edited
Loading

Could you add some tests on claim-iat.test.js file to assert that behavior is not changing for string payloads (proper stringified json and just a plain string like in your issue)

@lionello
Copy link
Contributor Author

@ziluvatar Done. Please check if it's what you had in mind.

@ziluvatar ziluvatar merged commit 7b60c12 into auth0:master Feb 20, 2019
@ziluvatar
Copy link
Contributor

Thanks @lionello 👏

@lionello lionello deleted the use_strict branch February 20, 2019 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ziluvatar ziluvatar ziluvatar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lionello @ziluvatar