This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Use sync fs for testing #789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I don't love it either, but maybe we can make a point to refactor it out after landing #624? |
Contributor
Author
|
I haven't looked at #624 but I wouldn't be surprised if you already ran into this and hopefully fixed it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to support atom/atom#11280.
So it seems like these tests were always racing: we depended on loading the
realpathbefore emitting change events. It’s just that we usually won that race. Now we use synchronous FS during tests to ensure we win the race.I don’t love this. It means testing isn’t quite doing the same thing as the Real Version. But I also don’t want to make dramatic changes and make #624 more difficult to merge.
/cc @thedaniel to make sure I’m not being crazy here.