This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Simplified the word delineating regex, and added support #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, kebab-case, ACRONYMCase. Added word boundaries. Removed extra capture groups.
Contributor
|
Sorry for the long delay in reviewing this. Can you explain a little further, perhaps with screenshots of examples, about what this now marks misspellings for that it didn't before. I just want to be extra careful about changing this word regex and make sure this is improving the experience. Also, would you be able to add some new specs as well to cover these additional cases? |
Took screen shots.
Author
|
Before the change you can see the camelCase words as well as capitalCASE words are found to be spelled incorrectly. The incorrectly spelled underscore_words are found to be correct.
after the change the camelCase and capitalCASE words are found to be spelled correctly and the incorrect underscore words are found to be incorrect. @kevinsawicki This is ready for review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the word delineating regex, and added support for camelCase, kebab-case, ACRONYMCase.
Added word boundaries.
Removed extra capture group.